P. L. Lim

Results 2472 comments of P. L. Lim

I dunno. Now that we have set the precedent, similar request might come up again and again. Maybe we should just stick with labels to stay flexible.

So let's say we're at the point where `main` points to `v8.1.dev`, so we have to maintain both `v8.0.x` and `v7.2.x`. We milestone a PR to `v8.0.1` and have the...

Also before you go too far, I would suggest you split the PR into one per sub-package if there is more LOC coming in.

CI failures look related; some of your changes here have failed the check of expected error messages.

@keflavich , we use towncrier now, so you are not supposed to modify CHANGES.rst directly. If fact you need to squash that change out and instead follow instruction at https://github.com/astropy/astropy/blob/main/docs/changes/README.rst...

Adding numba just to test one thing seems a bit of an overkill? I use my dev env for many things. I am not excited to have to install numba...

We also have to think about all the flavors of CI jobs that would be required to pull it in. CI is red anyway.

CI is failing so I think this is too risky to go into v7.1 given how close we are to feature freeze. I have turned this into draft for and...

> tides is a relatively heavy computation Probably also need benchmarking then?