P. L. Lim comments

Results 2472 comments of


                                            P. L. Lim

point_inside_ellipse returns true for points outside the ellipse

Is "x" minor or major? This part gets confusing. Here is the actual code: https://github.com/spacetelescope/stcal/blob/9093cbe8c43327329d1eced22ffd225c8f1f8eb2/src/stcal/jump/jump.py#L1285-L1291 Hmm the code isn't rendering for me, here it is again: ```python w = region.axis_major_length...

point_inside_ellipse returns true for points outside the ellipse

Huh, I guess it depends... https://github.com/spacetelescope/stcal/blob/9093cbe8c43327329d1eced22ffd225c8f1f8eb2/src/stcal/jump/jump.py#L705 ```python major_axis = max(ellipse[1][0], ellipse[1][1]) ```

point_inside_ellipse returns true for points outside the ellipse

Working on this over at https://github.com/spacetelescope/stcal/pull/456

point_inside_ellipse returns true for points outside the ellipse

@braingram , just so we're on the same page, when you say `[10, 5], # axis1, axis2`, were you defining the full width/length or just the semi-major/minor axes?

point_inside_ellipse returns true for points outside the ellipse

> Since (8, 0) falls inside a 10 x 5 ellipse (assuming first dimension is x). I think this statement is wrong if 10 is the full width of the...

Rename Spectrum1D to Spectrum or SpectrumAligned or similar

If you are taking votes, `Spectrum` is less to type... so 👍 from me.

Rename Spectrum1D to Spectrum or SpectrumAligned or similar

What about `NDSpectrum` like `NDData`? 😅

Rename Spectrum1D to Spectrum or SpectrumAligned or similar

@aragilar , alas, I think the answer is no. However downstream could do something like this: * https://github.com/spacetelescope/synphot_refactor/pull/413

WHL: enabling Python 3.14 wheels

Is OpenAstronomy aware of this? Thanks for the update!

MNT: Upgrade to WCSLIB 8.5

Thanks for the review, @mcara ! Good catch. I should have referred to https://github.com/astropy/astropy/pull/17886 . I think I addressed all your comments. Please re-review.