P. L. Lim

Results 2472 comments of P. L. Lim

@neutrinoceros , thanks for your thoughts and replies. I should probably make it clear that I am not out to shut this down, but I do want to express views...

> proof of concept PR That would make your intention clearer and maybe also avoid some unnecessary speculation when people can see concrete changes. However if it would take more...

Does that mean your original proposal above need some updating? 👀

Shouldn't the actual answer not needing astropy? 😆 ```python print("white") ```

Wow, @mhvk , you are brave... If you push https://github.com/astropy/astropy/releases/tag/v8.0.0.dev tag to *your fork*, I can try to run your PR branch here in https://github.com/astropy/astropy-integration-testing/ and see how many things...

@mhvk > how do I push a tag from elsewhere to my fork? As long as your branch has not diverged before the tag (and it should not), this should...

Oh OK. I thought you meant like one single test somewhere. 😅

> Just two failures I don't think those two are related. See https://github.com/astropy/astropy-integration-testing/pull/38#issuecomment-3578325673 :) That said, this is just a first rough pass. Good that nothing broke but we should...

Just so I understand, the first assert should return True, right, because the point is the center? Only the other 2 asserts are wrong?