P. L. Lim comments

Results 2472 comments of


                                            P. L. Lim

TST: Use get_pkg_data_filename, delete unused fixture, delete unused notebook data, do not use tempfile, other clean-ups

As far as I can understand the linked convo... * https://github.com/spacetelescope/jwst/issues/8311#issuecomment-1976932336 acknowledged that the original problem with `_jail` was indeed fixed but unreleased at the time (it is now released);...

TST: Use get_pkg_data_filename, delete unused fixture, delete unused notebook data, do not use tempfile, other clean-ups

`_jail` is gone. RT at https://github.com/spacetelescope/RegressionTests/actions/runs/16206919637

Added section about closing formatting PRs without review

I think there was also a comment at the meeting that this document should be linked from astropy core dev docs?

[DRAFT] Adding a utf8trunc function to io.votable.util.

Well, I had to define it in seconds, so the human month is approximate and can be 4 or 5 because of uneven months and so on. https://github.com/pllim/action-astropy-stalebot/blob/aed4b8aa0b1cbdb4ef09d476e46ebe0768e75d4b/stale_pull_requests.py#L37

linkcheck: replace 'linkcheck_allowed_redirects' default sentinel with boolean false value

FWIW this PR turns our downstream job from red to green: https://github.com/astropy/sphinx-astropy/pull/82 Thanks!

Update associations regression tests to flight data

I have clarifying questions: 1. Are we talking about `test_associations_sdp_pools.py`, `test_associations_standards.py`, or both? Any other test module that isn't obviously named that I should also cover? 2. For every existing...

Update associations regression tests to flight data

Note to self: * https://jwst.readthedocs.io/en/latest/jwst/associations/index.html

Update associations regression tests to flight data

> The first step will be to understand the total space under which we should be testing. From a read through the docs, looks like theoretically, the possible combos are...

Update associations regression tests to flight data

Side quest: * https://github.com/spacetelescope/jwst/pull/9458

Update associations regression tests to flight data

These are actually missing from Artifactory, so I am just going to remove them from parameterization. Even when defined, these are not used. https://github.com/spacetelescope/jwst/blob/b38915d73031c771332b543bf991ca64bd0e332e/jwst/regtest/test_associations_sdp_pools.py#L55-L59 https://github.com/spacetelescope/jwst/blob/b38915d73031c771332b543bf991ca64bd0e332e/jwst/regtest/test_associations_sdp_pools.py#L70-L74 https://github.com/spacetelescope/jwst/blob/b38915d73031c771332b543bf991ca64bd0e332e/jwst/regtest/test_associations_sdp_pools.py#L90-L94 https://github.com/spacetelescope/jwst/blob/b38915d73031c771332b543bf991ca64bd0e332e/jwst/regtest/test_associations_sdp_pools.py#L125-L129