Paweł Lesiecki
Paweł Lesiecki
@AlexGalays For now postcss-loader and cssnano will probably help.
Hello, just to let you know that with 50220c1b80c41c8757c56e3727bd718b95a0370b (instead of d472863dae649efcfe1de039facf69a233209182) I see consistent results for each case. Maybe it's worth reconsidering. edit: this idea is no longer valid
I've added few more tests for composition
Looks like a removing this line below can help https://github.com/tivac/modular-css/blob/e64362e087f4ae6113a1b622e59dab827a9f2e97/packages/processor/processor.js#L513
`PASS packages/processor/test/composition.test.js`; rest of the snapshots likely should be regenerated.
> The problem with [50220c1](https://github.com/tivac/modular-css/commit/50220c1b80c41c8757c56e3727bd718b95a0370b) was, as I recall, that it outputs the composition selectors in the wrong order. Since we're already building the dependency graph including all the selectors,...
I suppose with that feature I would be able to migrate CSS Modules (with custom hashing fn) codebase to vanilla-extract 🤔
Let me emphasize this one more time. This plugin causes compilation invalidation right from the start in case of exporting multiple configurations from webpack config. Most importantly, with this plugin...
Not sure if you're aware but webpack supports multiple config. I've given you an example of incorrect behavior of this plugin. Tell me which part you don't understand, I'm happy...
I'll understand if you're not going to support multi config setup, but let's get it straight and at least make that statement. It'll be useful for future user to know...