Pascal Leroy

Note that #3385 addressed most of the problem. An arena might still make sense, but it would add code complexity.

Might be a duplicate of #3219.

In `OnAwake` we [add](https://github.com/mockingbirdnest/Principia/blob/91c156bc15c3052355090eb92df002ce344c5f14/ksp_plugin_adapter/ksp_plugin_adapter.cs#L718-L768) a bunch of `GameEvents` callbacks and of `TimingManager` callbacks. In `OnDisable` we [remove](https://github.com/mockingbirdnest/Principia/blob/91c156bc15c3052355090eb92df002ce344c5f14/ksp_plugin_adapter/ksp_plugin_adapter.cs#L1078-L1094) the `TimingManager` callbacks but we forget about the `GameEvents` callbacks. I wonder if...

I am a bit unsure what you have in mind for the deletion path. At the moment when the last manœuvre gets deleted, you are left with an empty flight...

I am fine with a "Reset" button, but I think we need a "Delete" (or "Hide"?) button too. There are times (e.g., warping over long distances) where you don't need...

Also, let's use `typename`, not `class`, for the template template parameters.

It would be nice if you could upload the journal somewhere (I recommend compressing it before the upload). I suspect that RSS is violating an invariant of KSP, but I'd...

Decoded stack trace: https://github.com/mockingbirdnest/Principia/blob/c0f911dc0e301755abf8847c656c264ed234c64a/ksp_plugin/interface_flight_plan.cpp#L492-L498 https://github.com/mockingbirdnest/Principia/blob/c0f911dc0e301755abf8847c656c264ed234c64a/ksp_plugin/flight_plan.cpp#L169-L199 https://github.com/mockingbirdnest/Principia/blob/c0f911dc0e301755abf8847c656c264ed234c64a/ksp_plugin/flight_plan.cpp#L395-L407 https://github.com/mockingbirdnest/Principia/blob/c0f911dc0e301755abf8847c656c264ed234c64a/ksp_plugin/flight_plan.cpp#L385-L385 https://github.com/mockingbirdnest/Principia/blob/c0f911dc0e301755abf8847c656c264ed234c64a/physics/ephemeris_body.hpp#L458-L474 https://github.com/mockingbirdnest/Principia/blob/c0f911dc0e301755abf8847c656c264ed234c64a/physics/ephemeris_body.hpp#L1166-L1200

The log also has suspicious messages like: ``` I1101 12:07:26.290994 7936 flight_plan.cpp:320] Loading a flight plan with 1 anomalous segments and status FAILED_PRECONDITION: At time -1.24250734787396073e+09 s, step size is...

I believe that the check tells us that `Ephemeris::FlowODEWithAdaptiveStep` is called with a `t` that is strictly less than the end time of the trajectory. (Note the word "believe", the...