Thomas De Smedt

Results 12 comments of Thomas De Smedt

@aminalaee : I`ve added some motivation in the PR description. A FastApi example `test/trinkets.py` ```python from fastapi import FastAPI, Request app = FastAPI(title='Trinkets') trinkets = [ {'name': 'nice'}, {'name': 'colorful'}...

Note that current fastapi treats these sub-apps independently in their documentation (e.g. documented with the local paths): `http://localhost:8000/api/v1/docs` ![image](https://user-images.githubusercontent.com/1620679/149639018-5eff243d-0d49-49ed-9b3c-b06e74780afc.png) (the current [fastapi docs on that topic](https://fastapi.tiangolo.com/advanced/sub-applications/?h=mount#check-the-automatic-api-docs) lag a bit behind)

@aminalaee did previous comments clarify the intent of this PR? If so would you consider reviewing it?

I've contributed a fix in #1416 that tries first to look up routes in the _local_ app, and then fails back to the global router. So with this fix both...

@Gi60s I've run in this too: it seems as if the `exceptionSkipCodes` options are not respected. The debugger pointed to https://github.com/Gi60s/openapi-enforcer/blob/fc78fe42b4cf2eba9200188cc8d45f8aaadf1577/src/definition-validator.js#L388 which in this case creates a `new Schema(new ValidatorState(data))`...

A test case: [openapi-enforcer-140.zip](https://github.com/Gi60s/openapi-enforcer/files/9785415/openapi-enforcer-140.zip)

@Kludex @alex-oleshkevich I can update this PR with the proposal (use `.` prefixed paths to have resolution local to the inner router) ... This will indeed improve backward compatibility, although...

I'd like a [ConfigDict](https://docs.pydantic.dev/2.7/api/config/#pydantic.config.ConfigDict) property `json_schema_serialization_nullable` that * when `True` includes any `None` default type/values as allowed in the schema documentation, and serialises these values when present. (current behaviour) *...

Is there a more elegant workaround to make `None` defaulted fields _optional_ rather than _nullable_ in json schema than this? ```python from pydantic import BaseModel, ConfigDict, Field, GetJsonSchemaHandler from pydantic_core...

Still an issue with `tabulate==0.9.0` ``` >>> from tabulate import tabulate >>> print(tabulate([['enabled','True']])) ------- ---- enabled True ------- ---- >>> print(tabulate([['enabled','True']],maxcolwidths=[10, None])) ------- ---- enabled True ------- ---- >>> print(tabulate([['enabled','True']],maxcolwidths=[10,10]))...