Patrick Steinhardt
Patrick Steinhardt
Thanks a lot for your review! Ain't got time to do another round of updates just now, but will do so later
Addressed all comments by @tiennou and fixed a memory leak introduced with the refresh code
> So, just for kicks, I've rebased the rest of the shallow code on top of that, and pushed it here, and it broke the only testcase I had ....
With regards to the format. It should in fact be the same format as "info/grafts", except for that every such line may not have any parents. Stated differently, each line...
Ah. One thing I noticed in your additions: you have a `git_grafts_geti` function, but indeed the grafting commits are not guaranteed to be in any particular order. Is the ordering...
> Yes, the code expects a separator after the OID, and thus for the shallow syntax the parser errors. I honestly don't get it, sorry. For the shallow clones I...
> IIRC git hard-errors on a broken .git/info/grafts, hence the separate parser I had. It doesn't, it just complains loudly and visibly on every git command that gets executed. I've...
I've rebased this branch on the latest master. I've also decided to bail out of the public API and thus removed the function `git_repository_shallow_roots` for now. I for myself am...
On Tue, Nov 05, 2019 at 09:19:35AM -0800, Etienne Samson wrote: > I share the concerns, and I agree we don't want to push more > design work here until...
> Is this still planned for 1.1? :) I'd very much like to aim for it. Let me re-roll and fix conflicts to get it going again.