pkrasicki

Results 58 comments of pkrasicki

@primetwig hi, any update on merging this? Is there more work that needs to be done? I really like this library, but this is a serious bug for me.

Hi, this would be a very useful feature, but difficult to implement correctly. Currently text is drawn on the same layer as everything else, so erasing text would also erase...

This would be a nice feature, but it doesn't make much sense to implement this, unless the map's colors can be changed to dark mode too. Bright colors of the...

Would it be possible for openstreetmap.org to provide a dark map?

Invert just by itself looks ugly, but you inspired me to play with other properties and I got this: Before: ![openstreetmap-default](https://user-images.githubusercontent.com/49721209/99157209-e86c8580-26be-11eb-8deb-cef85dda2508.png) After: ![openstreetmap-filters](https://user-images.githubusercontent.com/49721209/99157211-ec000c80-26be-11eb-8cf9-c982f27a7902.png) Code: `filter: brightness(0.6) invert(1) contrast(3) hue-rotate(200deg) saturate(0.3)...

I used this solution for dark theme in my app, [you can test it here](https://issviewer.com). [Full source here](https://github.com/pkrasicki/issviewer). I think it works pretty well in practice. Perhaps openstreetmap.org could do...

It looks like you use the Leaflet's attribution control in bottom right corner.

I had issues with that, so I did this instead: ``` let attrib = L.control.attribution({prefix: ""}); attrib.addTo(map); attrib.getContainer().classList.add("map-attribution"); let zoom = L.control.zoom({}); zoom.addTo(map); zoom.getContainer().classList.add("map-zoom"); ```

@MarcGodard > why is this still open Because (looking from the outside) the dev team can't agree on a solution that could be implemented right now. There have been PRs...

@fheft Your second suggestion looks great! But I think it would be even better if you made the reply button blue in dark theme. The gray color doesn't stand out...