pkgcheck icon indicating copy to clipboard operation
pkgcheck copied to clipboard

[Commits Bug]: false footer detection (mid paragraph)

Open Kangie opened this issue 1 year ago • 0 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

Current Behavior

Commit message contains the following:

net-misc/curl: add 8.11.0

There are a number of patches attached to this release. Normally
I'd generate a downstream tarball, or wait for the next point release,
however: we have signed tarballs for curl and that's worth preserving,
and the next point release has been pushed back until mid-December due
to upstream availability.

Signed-off-by: Matt Jolly <[email protected]>

pkgcheck outputs:

commit
  InvalidCommitMessage: commit 646acc672343: empty line 8 in footer
  InvalidCommitMessage: commit 646acc672343: missing empty line before tags
  InvalidCommitMessage: commit 646acc672343: non-tag in footer, line 6: 'and the next point release has been pushed back until mid-December due'
  InvalidCommitMessage: commit 646acc672343: non-tag in footer, line 7: 'to upstream availability.'

Expected Behavior

Footer detection should not start mid paragraph. Look for a line break above the footer.

master commit id

6166e0b9c023

HEAD link

https://github.com/Kangie/gentoo/tree/silly-curl

pkgcheck version

pkgcheck 0.10.31

pkgcore version

pkgcore 0.12.28

git remotes configuration

kangie-repo [email protected]:Kangie/gentoo.git (fetch) kangie-repo [email protected]:Kangie/gentoo.git (push) origin git+ssh://[email protected]/repo/gentoo.git (fetch) origin git+ssh://[email protected]/repo/gentoo.git (push)

Kangie avatar Nov 10 '24 00:11 Kangie