pkgcheck icon indicating copy to clipboard operation
pkgcheck copied to clipboard

BadCommitSummary: false positives when using upstream versions in commit messages

Open mgorny opened this issue 4 years ago • 1 comments

E.g.:

  BadCommitSummary: commit c0287c1018bb, summary missing package version '12.0.1_rc4': 'sys-devel/clang-runtime: Bump to 12.0.1-rc4'

Maybe it would make sense to do some normalization before comparing, e.g. drop non-alnum chars?

mgorny avatar Jul 05 '21 22:07 mgorny

If we want to handle this I'm not sure I'd drop all non-alphanumerics, perhaps just '_'.

Technically one could argue that's just bumping the ebuild version so upstream version formatting has no relevance in the commit message. :smile:

radhermit avatar Jul 18 '21 21:07 radhermit