pkgcheck icon indicating copy to clipboard operation
pkgcheck copied to clipboard

Make it possible to skip specific commits for StableRequestCheck

Open mgorny opened this issue 5 years ago • 2 comments

Long story short, thanks to this commit:

commit d8cbaa62dbf4abc31cc74d2cc12e3d0c7ac9b70a
Author:     Michał Górny <[email protected]>
AuthorDate: 2021-01-31 00:36:06 +0100
Commit:     Michał Górny <[email protected]>
CommitDate: 2021-01-31 01:06:37 +0100

    */*: Remove obsolete values from PYTHON_COMPAT
    
    Signed-off-by: Michał Górny <[email protected]>

pkgcheck now resets the 30 day waiting period for a large number of Python packages. I'd really use a quick option to make pkgcheck ignore it and count stabilization days from the previous commit.

mgorny avatar Feb 01 '21 20:02 mgorny

I think this could work using a more generic solution that ignores a given set of commit hashes for all git-related checks.

radhermit avatar Feb 01 '21 21:02 radhermit

On more thought I don't think this can be supported easily since it invalidates the current git cache design.

The cache only saves the most recent seen commit per CPV so if a user says to ignore that commit, there is no commit previous to that for a given pkg to use for checking. Adding more historical commits per pkg doesn't help either since it just runs into the same problem -- a user ignoring the oldest, cached commit for a pkg.

Combating this leads to incorporating the entire git history in the cache, generating temporary caches with the specific commits ignored, or having to perform some kind of dynamic lookup when hitting ignored commits -- all poor designs from a perf viewpoint. Probably the option causing the least performance hit would be dynamic lookups, assuming the number of ignored commits is kept to a limited amount.

radhermit avatar Feb 22 '21 11:02 radhermit