Philipp Kursawe

Results 205 comments of Philipp Kursawe

Thanks, I knew something is wrong there :) I'll add your proposed solution

So what kind of rule are you suggesting here? This plugin should warn if the user overrides/hides a saga-effect?

Added some more changes to #4 and docs. Could it replace the `yield-effects` rule? That would mean the rule would then have to first check if an effect is overridden,...

Is this really a case of valid code? Wouldn't the `take()` be called instantly and defeat the purpose of the following `yield`? If it is valid code, then the current...

Ok sure, that makes sense. However I am unsure of how to rewrite the rule to catch this case as valid. Maybe you can give it a try?

It seems to have been part of old code: ```bash $ git log -S '_encoder.safeToProceed()' ./src/CCapture.js commit 96b53f91c5cdff9d56185710f0cfce2dacc13b16 Author: Jaume Sanchez Date: Tue Mar 8 01:43:49 2016 +0100 new version...

Yes Matt, that looks good enough for me! Didn't know about the X509Certificate class until now, thanks! All I really need is the `pubkey` of the legacy object, so lets...