Philipp Kursawe

Results 205 comments of Philipp Kursawe

Upgrading to the newest 9.x version solved this. But it also rendered all previous snapshots invalid. Because now: ```diff - "fontFamily": "Ionicons" + "fontFamily": undefined ```

Maybe @xiaoyann can merge?

I think `shouldComponentUpdate` is not supposed to modify state? It's basically a read-only function that should have no side effects. I think maybe a better way would be to get...

Thanks for your efforts, lets hope the repo owners still maintain this repo and merge some PRs.

@thanhtunguet any updates on this?

Did you update your #114 accordingly?

@asasouza you don't happen to have the patch file to use? ;) How do you usually create those patch files?

Thanks, explanation is fine @asasouza! And thanks for the patch file. Next time I'll try it myself. There should be a way to attach such path files as temp fixes...

@asasouza any idea how we could use https://patch-diff.githubusercontent.com/raw/beefe/react-native-actionsheet/pull/88.patch for patch-package? It says "unrecognised patch file" when I drop it into the patches folder.

@JWWon TS complains the module can not be augmented: `Invalid module name in augmentation. Module 'react-native-actionsheet' resolves to an untyped module at 'c:/projects/app/node_modules/react-native-actionsheet/lib/index.js', which cannot be augmented.ts(2665)`