Piotr Kaminski

Results 29 comments of Piotr Kaminski

I'm mystified at the failing tests. They all pass on my machine (against Chrome 50), and the failure appears to be in an area completely unrelated to the change I...

Oops, fixed. The joys of working on multiple projects with different styles. :stuck_out_tongue_closed_eyes:

Did you mean module packaging? I didn't think those were really used with Angular, but I'm happy to take a PR. (I'm no longer actively working on this package.)

I don't think it's possible to delay enabling since it needs to decorate a bunch of built-in services to capture data, and this can only happen at config time. It...

Thanks @mrac, but `timingStack` being an array within a digest cycle is supposed to be an invariant that's assumed throughout the code, so I'd prefer to understand how this could...

Interesting. This probably hints at a way towards a fix, but given that there's an easy workaround that's now documented here, perhaps it's best to just leave it be.

Hey Adam, a typical workflow goes like this: 1. Find a scenario for your app where performance is unacceptably low. 2. Run through the scenario and look at the top...

A better option might be to dynamically add a `cancel()` method to the promise being returned, which could capture the `id` and invoke `cancelPath` when called.

FWIW, I don't think this is a good idea. You lose readability for a measly gain of 3-4 characters, and end up perilously close to Rust's "line noise" operators. I...

> Say you go on a 12 month holiday then come back to this. What's better for readability? That's really hard to say -- ask me again in 12 months....