Petr Kadlec

Shopsys framework has namespace `Shopsys\FrameworkBundle\Component\Cron` but interfaces `Shopsys\Plugin\Cron\SimpleCronModuleInterface` and `Shopsys\Plugin\Cron\IteratedCronModuleInterface` are in `Shopsys\Plugin\Cron\`. It is confusing ant I suggest move to one namespace in framework not in plugin bundle.

[shopsys] Remove unused dependencies and attributes

2

| Q | A | ------------- | --- |Description, reason for the PR| ... |New feature| No |[BC breaks](https://docs.shopsys.com/en/latest/contributing/backward-compatibility-promise/)| Yes |Fixes issues| ... |Have you read and signed our [License...

[framework] add typehints and return types in ImageFacade

2

| Q | A | ------------- | --- |Description, reason for the PR| Because I want... Yes it is not complex solution for all repository, but I do something in...

[framework] encapsulation of AdditionalImageData

2

| Q | A | ------------- | --- |Description, reason for the PR| immutable objects are more maintainable, datatypes are validated... |New feature| No |[BC breaks](https://docs.shopsys.com/en/latest/contributing/backward-compatibility-promise/)| Yes |Fixes issues| ......

namespaces of AdvancedSearch inconsistency

5

### What is happening There are two `AdvancedSearch` components - `Shopsys\FrameworkBundle\Model\AdvancedSearch` and `Shopsys\FrameworkBundle\Model\AdvancedSearchOrder` First is for products and second for orders... But first doesn't have product in name. I don't...

Unfriendly filepath for Elasticsearch configuration

5

### What is happening Elasticsearch indexes configuration is in json files with filepath `project-base/src/Shopsys/ShopBundle/Resources/definition/product/{domainId}.json`. It is not intuitive. I dont know what the number (domain id) means and what this...

confusing structure of configurations files

30

Project base contains: ``` Resources/config/services/commands.yml Resources/config/services/cron.yml Resources/config/services/data_fixtures.yml Resources/config/forms.yml Resources/config/services.yml Resources/config/services_test.yml ``` All of them are DI container configurations, but few of them are in directory `services`. I don't know why,...

`FpJsFormValidator.initModel` contains: ``` var element = this.createElement(model); ``` but `createElement` can return null and `initModel` throw unexpected exception.

| Q | A | ------------- | --- |Description, reason for the PR| I want a higher PhpStan level, and I do not want to update all files manually |New...

Meaningless message on Error in smoke test

1

### What is happening Error in smoke test shows only message, without route name or any other data set information, there is only `Shopsys\HttpSmokeTesting\RequestDataSet Object (...)`. Example of error message...