Philip Jenvey

Results 38 comments of Philip Jenvey

This is a pretty easy cleanup to accomplish, by: - adding `#[serde(default)]` to `Settings`, which makes the `Default` impl be utilized which lets us.. - kill the many `set_default` calls...

~~Upping the priority of this. The forms bug #480 made it evident how bad this `"failed"` feature is. Ops pointed out that clients may been uploading batches of forms with...

@jrconlin I'm gonna keep this open, the first 2 items were never finished. I added to the first one, we're probably calling get/validate multiple times unnecessarily, probably worth it to...

More observation of the UA strings in the duplicate #1027, such as [this comment](https://github.com/mozilla-services/syncstorage-rs/issues/1027#issuecomment-802374495)

Majority of these seem to be due to clients specifying the offset optimization, seen in `uri.path`. e.g. `/1.5/.../storage/history?full=1&newer=1586936981.88&offset=1587583914630:6&limit=1000&sort=oldest` That offset value is provided by the syncstorage server. I wonder how...

The db-tests could call `begin` themselves, but it probably make sense to provide the test w/ a `test_transaction` method that does this and rolls everything back at the end, similarl...

~~More than just the tests use implicit (sync) transactions, all the /info/* endpoints do too because they lack a collection. See #768~~ (#768 now fixed)

Another avenue to investigate w/ this issue: would this remove the need for `RUST_TEST_THREADS=1` under diesel? It's not clear why this is required for testing w/ diesel (I know the...

I haven't been able to trigger `block_alarm` on the latest master even with the lack of async here. Tracing the c# version it goes: - GoogleGrpcCredentials.GetApplicationDefaultAsync() - GoogleCredentials.GetDefaultCredentialAsync() (google-api-dotnet-client lib)...

Until we figure out how this call might block we'll defer it to actix-web's thread pool and leave this issue open to follow up on it later.