Philip Jenvey

Results 38 comments of Philip Jenvey

SQLAlchemy's MetaData's schema attribute is only guaranteed in later versions. I don't think we have a minimum SQLA version requirement, so we should fix this unless the version you're using...

If you're breaking the API at some point I recommend using the builder pattern for calls. It takes more effort to implement but is more resilient in the long term,...

The spike began on May 1st (suspicious). > and a breakdown of `google.rpc.BadRequest` AFAICT from [their general error docs](https://cloud.google.com/apis/design/errors) and the [firebase code docs](https://firebase.google.com/docs/reference/fcm/rest/v1/ErrorCode#ENUM_VALUES.INVALID_ARGUMENT) for INVALID_ARGUMENT "An extension of type...

flake8 complains about your lack of newline in the `__init__.py` version bump, we can just temporarily disable the check to merge this

A fix in: https://github.com/mozilla-services/autopush-rs/tree/feat/145 (TODO: put up a PR when there's less chance for merge conflicts)

#877 added some documentation for batch commit (describing its count of mutations)

The big blocker for this is actix-web, its 4.0 release will upgrade to futures 1.x. Currently in 4.0 beta4.

AFAIK you're right: it's not possible to use `async-trait` for `FromRequest` impls

Possibly from `SyncTimestamp::from_header`

I think the first couple suggestions are worth pursuing however I don't think we can easily kill `ErrorKind` enums as it would complicate our inclusion of a `backtrace` field (and...