Paweł Jankiewicz
Paweł Jankiewicz
I had the same problem. It turned out that I initialized the detector in the frame processor and not in the MainActivity. I solved it by moving the initialization to...
@davidbarsky @hawkw Thank you for the feedback. I will implement at least 2 compression crates behind feature flags. About the file extensions it is quite common to use it as...
@hawkw I managed to rewrite the PR according to your suggestions also I merged your latest changes from master. There were some hurdles with compression feature flag but I think...
@hawkw thank you for the detailed code review, I really appreciate it. The issues you mentioned were fixed. It turned out that IntelliJ didn't even compile the code with the...
@sw-dev-code Sorry for the delay I had some other priorities. I will get back to it this week.
@hawkw Thank you for the offer to finish this PR. I want to push this through. What I did: - resolved some minor conflicts with master - added a test...
@hawkw BTW I had a strange issue in reading the compressed log. ```rust let mut s = String::new(); let _ = decoder.read_to_string(&mut s); ``` The string is read ok but...
> Hmm, interesting. I think we should figure out what's going on here before we merge this PR. It could maybe be worth adding a test that reproduces this. It...
@hawkw I managed to find the issue with decoding. Before reading from the file the appender needs to be dropped to properly close the buffer. ```rust let expected_value = "Hello";...
@hawkw @sw-dev-code I think the PR is ready. I went back to our previous discussions and resolved some issues - hopefully I didn't miss anything. I checked clippy, tests, formatting...