Antoine Pitrou

Results 822 comments of Antoine Pitrou

@vibhatha Can you please focus on Arrow 10.0.0 release blockers for now? Thank you.

If this is meant to be a public API, then I'd expect a design discussion on the ML.

@anjakefala You need to add to the `LogicalType` union, not to the `Type` enum (which is for physical types). Also cc @emkornfield

> It would not be too easy to implement the half-precision floating point comparison logic since java does not have such a primitive type. While not effortless, it should be...

I agree with @emkornfield that ordering issues seem largely orthogonal, as they also affect FLOAT32 and FLOAT64 types.

> 1. Inability for meaningful contributors to approve pull requests (only Arrow PMC members are able to approve PRs to be merged) This seems to be misleading since: 1) any...

cc @lidavidm @emkornfield : could you give this a look?

It would probably be easier to use a git submodule (I wonder why that's not the approach being used in `parquet-mr`), but in any case reference files should go into...

@lwhite1 Could you perhaps review this? I can't really comment on the details of the Java code, myself.