Peter Jaszkowiak
Peter Jaszkowiak
~~I don't think that is very important, given most PRs aren't marked as merged as it is today. The solution to that is for GitHub to add a way to...
Oh hmm for some reason I thought anything part of a rollup wasn't closed as merged. Not sure why I thought that. Regardless, GitHub has the ability to squash-merge a...
> I haven't found a GitHub API that would allow me to squash without doing the actual merge It's a tad convoluted, but I think bors could open a new...
> The bot should be generic (=usable for any repository) and it would be quite annoying if it required another repository to perform one of its features. Yeah unfortunately it's...
Actually there is an even more convoluted way to achieve this: - [create a copy of the branch](https://docs.github.com/en/rest/git/refs?apiVersion=2022-11-28) - create a new PR from the copy - squash merge that...
Agreed, I'm thinking we can at least have ```rust impl OpaquePriority { /// Returns a new instance of the highest /// possible thread priority. This may be equal /// to...
I think that's a fair compromise
Previous zulip discussion: https://rust-lang.zulipchat.com/#narrow/stream/219381-t-libs/topic/Mark.20unimplemented.20ACPs In there it seems like there's a general consensus on the "mark accepted, don't close until implemented" idea. (Five 👍s on @cuviper's message). Going to nominate...
Hello @J-ZhengLi, Thanks again for working on this! I ran a [poll of clippy contributors](https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/lint.3A.20recommend.20LazyLock.20instead.20of.20once_cell.20Lazy.20or.20laz.2E.2E.2E/near/453441539) and the conclusion is that we'd like both `lazy_static` and `once_cell::sync::Lazy` handled by a single...
Your example isn't great given the owned branch creates a reference and then converts it back into an owned string. Makes me think you should just use `.as_ref().trim()` instead. Maybe...