Vladimir Piskarev
Vladimir Piskarev
The latest change is ready for review: https://github.com/eclipse-lsp4j/lsp4j/pull/809/commits/3982fd3ba22c2ae71cebafdc3647dbfd347ff770.
Just a note that I'm working on a fix.
@msujew Sure, my fix is actually based on using the `DelegatingSaveable` :-) Thank you!
If there are no objections, the fix will be submitted as a separate commit in a bigger PR for #9079, which will also fix a number of other issues; I'm...
I have submitted PR #13916, which contains a fix for this issue.
It does not look like a good idea to try to use `CompletableFuture.getNow` for obtaining the current partial result, as it would really break the method contract: it is intended...
Sounds like a good idea to me. However, from the API point of view, I would rather suggest adding the following methods to the `SemanticTokensLegend`: ```xtend int encodeTokenType(String tokenType) int...
The error is thrown from the constructor of the `Range` class: https://github.com/eclipse-theia/theia/blob/9b0e47f23661070e15602c90dd68a298aced2902/packages/plugin-ext/src/plugin/types-impl.ts#L457-L459
The error is thrown because the arguments passed to the `Range` constructor are in this case `Position`-like objects deserialized from the command URI query at https://github.com/eclipse-theia/theia/blob/09051c419afb34dc0b2b10d4cb4f0e19962d593f/packages/core/src/browser/command-open-handler.ts#L38 while the constructor expects...
Note that the code in `types-impl.ts` was initially copied from https://github.com/microsoft/vscode/blob/1.37.0/src/vs/workbench/api/common/extHostTypes.ts. Since that time, VSCode has evolved to relax the constraint in the `Range` constructor: https://github.com/microsoft/vscode/commit/0fd15bb21d6132ff3514a9df465cd8e07f22346b. It looks like the...