Vladimir Piskarev

Results 101 comments of Vladimir Piskarev

> When I hover over the little red triangle that signifies "removed line", I can get the decorations to keep flickering between the red bar and the triangle icon. This...

> Thanks for this very useful PR. Thanks for reviewing this PR. > The main issue I have is the direct use of monaco API outside of the monaco package:...

@tsmaeder I have addressed a number of smaller items. It would be great if you could review and resolve them, or provide further feedback if necessary. This would make it...

@tsmaeder I think I have addressed all of the remaining items except https://github.com/eclipse-theia/theia/pull/13104#discussion_r1497314715. Could you please review and resolve them, or provide further feedback? Thank you.

(In reply to https://github.com/eclipse-theia/theia/pull/13104#issuecomment-1983041968 and https://github.com/eclipse-theia/theia/pull/13104#discussion_r1497314715) If I understand your comments correctly, you ask me to add the necessary API to the `monaco` package in Theia and use it instead...

OK. I'm trying to come up with something in the meantime. Let us see how it goes...

Hi @tsmaeder, The latest commit gets rid of monaco *internal* API use in `dirty-diff-widget.ts` by adding the necessary API to the Theia `monaco` package and using it instead. Essentially, the...

@tsmaeder I'm really glad to hear that you are fine with this PR now. Thank you for your review and approval.

The 'sneaky throws' change is ready for review: https://github.com/eclipse-lsp4j/lsp4j/pull/809/commits/4de67343c5a30bf9110ace2969c832708e06e1df :-)

I have another approach in the works, which does not use sneaky throws. It is based on the fact that an `Endpoint` is not expected to throw a checked exception....