Radim Řehůřek comments

Results 329 comments of


                                            Radim Řehůřek

[WIP] Implement position-dependent weighting to fastText

@Witiko could you check https://groups.google.com/g/gensim/c/5mAeWrQN7lg/m/7Ul-uMJWBAAJ please? (FYI, in case you're not getting the mailing list notifications). Thanks!

Memory leak iterating over WikiCorpus get_texts()

Thanks for the comprehensive report! > then it increased steadily until I killed it at this point What increased steadily? The RSS column looks pretty stable here. > where after...

Memory leak iterating over WikiCorpus get_texts()

Thanks for the clarification. Definitely worth an investigation – I don't know what is using up that memory. Please note Python has its own memory allocator, which doesn't necessarily return...

FastTextKeyedVectors.load_word2vec_format() does not initialize correctly.

I'd also prefer a clear error message, telling the user a) what's wrong (the data on disk doesn't contain what the information needed) and b) what to do instead (use...

Self provided normalization function is not used.

Correct! If you found a bug, please fill in the issue template fully. Otherwise I'll close this.

random.RandomState with different versions of numpy has vastly different performance

Thanks for reporting. What was the difference in `random.RandomState` that you nailed it down to? We should replace `RandomState` if it's deprecated. What should it be replaced with, is the...

random.RandomState with different versions of numpy has vastly different performance

Agreed. A 60x slowdown is really worrying.

random.RandomState with different versions of numpy has vastly different performance

@zygm0nt do you think you could take care of *all* the places gensim uses the old (slow) numpy RNG?

random.RandomState with different versions of numpy has vastly different performance

Yeah, let me reopen. Thanks!

random.RandomState with different versions of numpy has vastly different performance

Sure! The code style and instructions for Gensim are here: https://github.com/RaRe-Technologies/gensim/wiki/Developer-page Thanks.