gensim icon indicating copy to clipboard operation
gensim copied to clipboard

Published 20 hours ago • verified publisher icon piskvorky

Self provided normalization function is not used.

Open cosmozhang opened this issue 3 years ago • 3 comments

https://github.com/RaRe-Technologies/gensim/blob/5bec27767ad40712e8912d53a896cb2282c33880/gensim/models/tfidfmodel.py#L525

self.normalize = matutils.unitvec does not allow users to use self-defined normalization function.

cosmozhang avatar Oct 05 '21 23:10 cosmozhang

Correct! If you found a bug, please fill in the issue template fully. Otherwise I'll close this.

piskvorky avatar Oct 06 '21 06:10 piskvorky

Can I just send out a pull request? But I do not know to which branch I shall compare against.

cosmozhang avatar Oct 06 '21 21:10 cosmozhang

@cosmozhang Yes - PRs for consideration should generally be against the develop branch. Unless the problem & fix is trivial/self-evident, it may also help to include inside the PR a test case that fails before, and succeeds after, the fix is applied.

gojomo avatar Oct 06 '21 22:10 gojomo