Felipe Martínez

Results 64 comments of Felipe Martínez

Sure, it can just make it a separate task instead. I could write it in a Kotlin script, but AFAIK it would mean that the `build.gradle` file must be converted...

Yeah that's true, I'll write it in Kotlin then.

I've migrated the `build.gradle` file to Kotlin and also translated the fetch script into Kotlin. The script is in a separate file which makes it neater, but apparently you can't...

Where should I add the info on how to fetch the instances to the README? Maybe we should add a CONTRIBUTING file.

I've traced down the issue to using the `PaddingValues` passed to the `Scaffold`'s content. What's really weird is that it doesn't matter *how* you use it, even logging it causes...

Okay, I've traced down the (sort of) root cause. It seems like, for whatever reason, when in `MainPostListingsContent` we create lambdas for the `PostListings` callbacks (e.g. `onUpvoteClick`) we must make...

Yeah I don't know, I've seen tons of posts online about bad LazyColumn performance it could definitely be Jetpack Compose's fault. Or maybe the issue is that recomposition of a...

I think it does recompose since it needs to know what has changed, which is only possible by calling the composable function again. It's only after calling this method that...

It does seem like when a deadline is missed, the main time hog is the `PostListing` composable: ![image](https://github.com/dessalines/jerboa/assets/3885705/a7a6f0af-585d-4316-b1e8-5628816a5501)

I followed [this guide](https://medium.com/androiddevelopers/jetpack-compose-composition-tracing-9ec2b3aea535). > Looks like the CircularIcon might be the issue? It does look like that but the graph doesn't make much sense. For example, it's implying that...