Piotr Rżysko comments

Results 59 comments of


                                            Piotr Rżysko

Introduce SSL config for Kafka

Hi @gadomsky, would you mind rebasing this branch on the latest master?

basic auth for schema registry

Hi @gadomsky, would you mind rebasing this branch on the latest master?

Add a linter to the project

You're absolutely right, let's make the guide a bit more lenient :).

Reduce deprecated usages

Have you checked if `RestTemplateHermesSender` is no longer used by `hermes-client` users? I mean our internal users, as it is probably impossible to determine how many (if any) external ones...

Add possibility to skip events

> if subscription have some lag than I can order retransmission from the future and events that were lagged will be discarded(skipped) This is a correct explanation.

Clean up management/console configuration

Great! As far as I know, no one is working on this task, so feel free to take care of it.

Investigate and consolidate HTTP clients

Resolved in #1620

feat(sql): add approx_count_distinct() SQL function

Thanks for the feedback. Sounds good. I'll work on adapting the functions for parallel execution.

feat(sql): add approx_count_distinct() SQL function

Hi, I added parallel execution to approx_count_distinct. I don't know yet how to handle one case: https://github.com/questdb/questdb/pull/4083/files#diff-d7791316bd7653614acb4683fc3a68509559c304b46f7834e361dbb2f5669890R135-R136. I need to dig deeper to understand if my reasoning described in the...

feat(sql): add approx_count_distinct() SQL function

No problem :). Thanks for running the queries. In the meantime, I'll try to address the comments you've already posted.