pionere

Results 14 comments of pionere

@icculus : you might want to look at [this](https://github.com/pionere/devilutionX/blob/master/.github/workflows/nightly.yml) example. It checks every day if there was a commit in 24 hours, and runs only if necessary (`should_run`).

NOTE: Originally this issue was about Direct3D vs Vsync, but after checking the code the problem seems to be more common (-> changed the title). As far as I understand...

> The application can detect the minimized state and avoid rendering, if you want an application level solution. Sure? I tried to check WINDOWEVENTs, but for some reason it did...

@slouken : with the latest [PR](https://github.com/libsdl-org/SDL/pull/6518) all but [one](https://github.com/libsdl-org/SDL/pull/5315/commits/155c202951e24c9be95815ab41bcd7e546816421) commits are integrated. I'm hesitating now how to proceed, because I'm not really sure what is the best way to solve...

I'm not really familiar with the code, but just having a quick glance at the code from [line 1075](https://github.com/libsdl-org/SDL/blob/eef4d3c86a653f91b7221c80809ba8ab56f94cf1/src/events/SDL_keyboard.c#L1075) of SDL_keyboard.c seems to be wrong (added by #5398). The branch...

> That branch is needed to keep compatibility with the behavior pre-`SDL_HINT_IME_SUPPORT_EXTENDED_TEXT`. What do you mean? Lines 1075-1079 are the same as lines 1061-1065. There is nothing in-between which uses...

> I doubt this would cause this issue tho. That is quite possible. Nevertheless, I'm going to create a PR for that.

checked the generated code on godbolt.org

what correctness? what benchmark setup? what results? which point are you questioning?

You know what? Forget it. @icculus : I would suggest that you reconsider who handles which PR. I'm a contributor, not your slave. I have much better things to do...