mediadevices icon indicating copy to clipboard operation
mediadevices copied to clipboard

fix(deps): update github.com/kbinani/screenshot digest to a8a2c5d

Open renovate[bot] opened this issue 1 year ago • 2 comments

This PR contains the following updates:

Package Type Update Change
github.com/kbinani/screenshot require digest b87d318 -> a8a2c5d

Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

renovate[bot] avatar Aug 12 '24 01:08 renovate[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 44.67%. Comparing base (f2a550d) to head (8d91eda). Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #578   +/-   ##
=======================================
  Coverage   44.67%   44.67%           
=======================================
  Files          80       80           
  Lines        5498     5498           
=======================================
  Hits         2456     2456           
  Misses       2875     2875           
  Partials      167      167           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 12 '24 01:08 codecov[bot]

ℹ Artifact update notice

File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 3 additional dependencies were updated
  • The go directive was updated for compatibility reasons

Details:

Package Change
go 1.19 -> 1.23.2
github.com/gen2brain/shm v0.0.0-20230802011745-f2460f5984f7 -> v0.1.0
github.com/jezek/xgb v1.1.0 -> v1.1.1
golang.org/x/sys v0.18.0 -> v0.24.0

renovate[bot] avatar Aug 20 '24 17:08 renovate[bot]

kbinani/screenshot requires Go 1.21 now

at-wat avatar Oct 22 '24 07:10 at-wat

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

renovate[bot] avatar Oct 22 '24 07:10 renovate[bot]

# github.com/kbinani/screenshot
Error: ../../../../go/pkg/mod/github.com/kbinani/[email protected]/darwin.go:41:14: error: use of undeclared identifier 'SCScreenshotManager'
            [SCScreenshotManager captureImageWithFilter:filter
             ^
1 error generated.
make: *** [test] Error 1

Latest kbinani/screenshot seems using SCScreenshotManager and it's supported since macOS 14.0. The self-hosted runner seems using macOS 12 and already EOL-ed on Sep 2024.

/Users/admin/actions-runner/_work/mediadevices/mediadevices/homebrew/bin/brew
Warning: You are using macOS 12.
We (and Apple) do not provide support for this old version.

@edaniels does the machine support newer macOS? And do you think we need to support older macOS?

at-wat avatar Oct 22 '24 09:10 at-wat

# github.com/kbinani/screenshot
Error: ../../../../go/pkg/mod/github.com/kbinani/[email protected]/darwin.go:41:14: error: use of undeclared identifier 'SCScreenshotManager'
            [SCScreenshotManager captureImageWithFilter:filter
             ^
1 error generated.
make: *** [test] Error 1

Latest kbinani/screenshot seems using SCScreenshotManager and it's supported since macOS 14.0. The self-hosted runner seems using macOS 12 and already EOL-ed on Sep 2024.

/Users/admin/actions-runner/_work/mediadevices/mediadevices/homebrew/bin/brew
Warning: You are using macOS 12.
We (and Apple) do not provide support for this old version.

@edaniels does the machine support newer macOS? And do you think we need to support older macOS?

@Otterverse would you be able to update that machine? @at-wat I no longer have access to that machine, sorry!

edaniels avatar Oct 22 '24 11:10 edaniels

And I think we can just support the latest Mac version at this point

edaniels avatar Oct 22 '24 11:10 edaniels

https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/ M1 macOS runner seems be available for OSS. I'm gonna try this

at-wat avatar Oct 22 '24 22:10 at-wat

macos-latest jobs are already running on M1 mac. image

Then, we can just unuse self-hosted runner.

https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories

at-wat avatar Oct 22 '24 22:10 at-wat

Oh great!

edaniels avatar Oct 22 '24 23:10 edaniels