James Hurst

It's not currently possible, because client certificates are not supported in OpenResty cosockets. However, lots of work has gone into this and I believe the feature was recently merged. This...

What do you mean by "deal with master failover" exactly? Redis Sentinel can promote a replica to master in the event of failure, so from the point of view of...

No worries, yes you're thinking about it in the right way. You might want to check the result from `set_keepalive`. For example. if there are bytes left on the wire...

I'm not sure I understand your problem. You want to avoid sending `auth` and `select` over connections if they are being reused? Persistent connections are only there to avoid the...

Well, firstly, have you measured how much time `auth` and `select` really take? You get your desired 10k req/s on DB 0 with no password? I think connections obtained from...

Thanks for the contribution! How are those comments generated? I am concerned that they could easily fall out of date with changes. Is `_doc.lua` some kind of tooling convention? I'm...

Yes, it looks like with the "single shot" interface (`request_uri`) we don't read the trailers. I don't remember if there was a reason for this or not, but perhaps it...

Thanks! Looks good - I will review properly as soon as I have a bit of time.

Hey, I realise this is ancient but I think this is now addressed here: https://github.com/ledgetech/ledge/pull/186/commits/b6bd6e19d10a4533793aa560a7215946042f0726

It is "supported", in the sense that it won't get in the way of you sending a range request. The important work of a range request happens on the server...