Daniel Clark

Results 82 comments of Daniel Clark

Gotcha - thanks for the suggestions! We'll consider this and maybe some other options to better support this use case. Btw, in the meantime, I wonder if using [GKE ConfigSync](https://cloud.google.com/anthos-config-management/docs/config-sync-overview)...

Hi @bjakubski, Your cluster may not have the latest release which includes the `.managedAlertManager` field. What does this command return? ```bash kubectl get deploy gmp-operator -ngmp-system -ojsonpath="{.spec.template.metadata.annotations['components.gke.io/component-version']}" ``` If it's...

Hi @bjakubski, Apologies for the delayed response. So this `.managedAlertmanager` is actually set through the default value of `{"configSecret":{"key":"alertmanager.yaml","name":"alertmanager"}}` in our [manifests](https://github.com/GoogleCloudPlatform/prometheus-engine/blob/v0.5.0/manifests/setup.yaml#L1079-L1083) (generated as a [kubebuilder marker](https://github.com/GoogleCloudPlatform/prometheus-engine/blob/v0.5.0/pkg/operator/apis/monitoring/v1/types.go#L57)). This allows the...

Aside from rebasing - we'll want to benchmark this change to catch any performance regressions - cc @saketjajoo

Hi @Zebradil - thanks for reporting. Can you detail your use case here a bit? Are you doing [closed-box monitoring](https://cloud.redhat.com/blog/closed-box-monitoring-the-artist-formerly-known-as-black-box-monitoring), e.g. something like [`blackbox-exporter`](https://github.com/prometheus/blackbox_exporter) in Prometheus? Or is your target...

Actually this may be safe as we use relabeling rules to [overwrite](https://github.com/GoogleCloudPlatform/prometheus-engine/blob/b353ebdee8236c5daa7c6cc93d0d23c0d3c1cd13/pkg/operator/apis/monitoring/v1/types.go#L789-L793) the `PodMonitoring`'s name as the `job` label in the operator. Taking another look...

Yea - so the biggest risk with relabeling both metric paths to the same `job` is potential collisions if the same metric name and label set exists at both paths,...

Cool - we should definitely add a validating webhook check for this case, thanks for raising! > I don't get what would be the downside of adding an endpoint_index label....

Hi @m3adow - yes indeed the best workaround for now is to use different `PodMonitoring`s. We haven't had a lot of recent demand for this feature so we've deprioritized it...

Related question for dcgm-exporter https://github.com/NVIDIA/dcgm-exporter/issues/165