Daniel Clark

Results 82 comments of Daniel Clark

Hi @spagarwal, Currently kubelet scraping is enabled on/off through the [`OperatorConfig`](https://github.com/GoogleCloudPlatform/prometheus-engine/blob/83d012e29b74306dbee3e367270476ae86f4531a/doc/api.md#kubeletscraping) with a [hardcoded](https://github.com/GoogleCloudPlatform/prometheus-engine/blob/83d012e29b74306dbee3e367270476ae86f4531a/pkg/operator/collection.go#L498-L541) scrape config that uses the same metrics relabeling as what [kube-prometheus](https://github.com/prometheus-operator/kube-prometheus/blob/90f30144c48fa495a125c0a51114a8dac8316d81/manifests/kubernetesControlPlane-serviceMonitorKubelet.yaml#L14) uses. So configuration through our...

Gotcha - we don't support this in our CRs right now. Our general philosophy with the kubelet was to limit relabeling capabilities because they can be easy to break things...

They have to be hard-coded values. We do support adding pod-labels when using PodMonitoring [`.spec.targetLabels.fromPod`](https://github.com/GoogleCloudPlatform/prometheus-engine/blob/main/doc/api.md#targetlabels) but we don't provide PodMonitoring-based scraping for the kubelet, for the reasons I stated above....

Yes we can keep it open until we add this flexibility.

Whoop sorry - didnt see this was a draft

Hi @ego93 - yes this is a known issue with a tentative fix in https://github.com/GoogleCloudPlatform/prometheus-engine/pull/474

Thanks for the contribution @ajayk. @yqlu - what's our policy here? Should new examples also come with a yaml snippet ([example](https://github.com/GoogleCloudPlatform/prometheus-engine/blob/dbc5cf0905975bbc74c9fa9da75b13983051c8ff/examples/activemq/exporter.yaml.snippet)) of what the actual exporter setup should look like...

Hey @TheSpiritXIII - just cleaning out old review requests for myself. Is this still relevant? If we want to merge, feel free to rebase and update. Otherwise, I vote either...

Hi @shpml and @bjakubski, > I recently had an issue with too many metrics being scraped as I had enabled kubeletScraping for testing, after I removed the kubeletScraping config from...

Hi @shpml and @bjakubski, Apologies for the delayed response. I'm just returning back from leave over the holidays. Thanks for making this use-case more clear and I think I see...