Zohar Malamant

Results 72 comments of Zohar Malamant

I have time available between 4 Jan 2021 and 30 Dec 2022.

Can you write a unit test that tests that this does the right thing and also that existing user code doesn't break with this change? Thanks.

You could do it by created timestamp so you don't need to regex or otherwise interpret the numbers.

Here's a list of all of the `__init__.py` files that need docstrings: - TODO

Hi! Sorry for the late response. This seems like a pretty cool project. I'm not aware of anyone using Java at Equinor, however I think it's a nice idea worth...

Seems like the type for `ECL_CHAR` is wrong. It should be `ecl_data_type`, but you've specified it to be `int`. https://github.com/equinor/libecl/blob/be6c344fea89cafc36f68120f01dd42b966711dc/lib/include/ert/ecl/ecl_type.hpp#L72-L75 https://github.com/equinor/libecl/blob/be6c344fea89cafc36f68120f01dd42b966711dc/lib/include/ert/ecl/ecl_type.hpp#L105 https://github.com/equinor/libecl/blob/be6c344fea89cafc36f68120f01dd42b966711dc/lib/include/ert/ecl/ecl_type.hpp#L83 https://github.com/bytedeco/javacpp-presets/blob/d0b68ed3bccb355badb0b2134509f0182cded6a1/libecl/src/main/java/org/bytedeco/libecl/presets/libecl.java#L276

Are there any updates on this, @matteodg ?

You need to have some C++ compiler (eg. Visual Studio 2015+), CMake, Python and git. Open a new command prompt (or powershell), make sure all are accessible, and then you...

The simplest thing you can do is use [WSL](https://docs.microsoft.com/en-us/windows/wsl/install-win10), which installs an Ubuntu VM that you can interact with as a Windows user. Then simply `pip install libecl`. Unfortunately, you...

The reason we don't have a Windows wheel is because of lack of time really (and because internally nobody uses Windows for libecl-related stuff). I've recently acquired Windows 10 +...