Zohar Malamant comments

Results 72 comments of


                                            Zohar Malamant

add_t_step not correct for long timespans

EclSum's `add_t_step` doesn't deal with eg. leap seconds. This would necessitate a refactor which isn't feasible with our budget of 0kr. https://github.com/equinor/ecl/blob/007f000ba97b04b670217aa425220f907c022e79/python/ecl/summary/ecl_sum.py#L307-L308

add_t_step not correct for long timespans

Okay nevermind. It's due to floating-point conversions. `ecl` accepts simulation-seconds as a 32-bit float. The number of seconds don't fit into this and thus it gets automatically rounded down: ```python...

smspec_node is_historical has false positives

Is this still relevant? Looks a lot like https://github.com/equinor/ecl/pull/707 . It'd be nice to have documentation of how to detect historical data.

smspec_node is_historical has false positives

Cool. Does ECLIPSE have any documentation of what constitutes historical data? Or is this a naming convention and we just have to guess?

smspec_node is_historical has false positives

Poking @markusdregi , @eivindsm , et al.

Crash when importing TRANNNC for dual porosity model

Is this still an issue?

Standard python file handle does not fly - update docs

Could we perhaps just extend the functionality so that it *can* handle Python file handles? They're all the same C stuff under the hood.

Option to load UNSMRY data as 32 bit floats

We did some Sherlock Holmes-ing. It seems very feasible. While the following isn't the only places where we end up while reading UNSMRY data, it seems to be one of...

Various problems with the new smspec-code

If the ResInsight PRs haven't been upstreamed in this repo, then we should do it.

Roadmap - Ecl

We should schedule a meeting regarding this. If you could do it when you have time and brain capacity then it would be nice. Include @eivindjahren @lars-petter-hauge .