Matthew Zipkin

Results 673 comments of Matthew Zipkin
trafficstars

I plan on reviewing this in depth but the first comment I have is this: I think we should try to limit Bob just to UI functions and keep wallet...

You might want to follow / review https://github.com/handshake-org/hsd/pull/639 as well. @anunayj is also interested in a HIP-9 standard custom script and we are working on adding custom script signing to...

Yeah so if you look through `wallet/account.js` in hsd theres a bunch of functions like `deriveChange()` `deriveReceive()` and `syncDepth()` which calls both of those. Then when you get an account...

This feature will need to be added to the C app that runs on the actual device. You can open an issue here as a TODO: https://github.com/handshake-org/ledger-app-hns it may take...

Airdrop coins require 100 confirmations before they are spendable. That is a network consensus rule and applies to all outputs of all coinbase transactions. Try again in one day ;-)

Airdrop coins require 100 confirmations before they are spendable. That is a network consensus rule and applies to all outputs of all coinbase transactions. Try again in one day ;-)

Agreed - I think you should re-open the issue for that feature request (just rename it)

https://github.com/kyokan/bob-wallet/blob/ee43daaa3aaabc268a9284cc77af637204052f7d/app/background/wallet/stats.js#L177-L189 I think there's a few things wrong with this actually. First, CLAIM lockup isn't `network.coinbaseMaturity`, it's `network.names.lockupPeriod` (but I think this gets caught by the CLOSED check anyway, before...

Could you elaborate? I see this claim as being processed a few hours ago: ``` [D:2021-10-26T00:08:39Z] (mempool) Added claim 383ff56f4e5597b160e55e87090b652eeb1194699853acf5b89b032c4f4bda42 to mempool (name=livesmag, claims=1). ``` Are you saying you do...

Maybe this was your invalid claim? ``` [D:2021-10-26T12:28:24Z] (mempool) Invalid covenant for 2f2d7dc2573384743ab543b711795bf87bb8466cf6702b9b6dc89110ab83df64 (91281): bad-claim-commit-hash. [D:2021-10-26T12:28:24Z] (peer) Rejecting CLAIM 2f2d7dc2573384743ab543b711795bf87bb8466cf6702b9b6dc89110ab83df64 (X.X.X.X:XXXX) code=invalid reason=invalid-covenant. [D:2021-10-26T12:28:24Z] (peer) Sending reject packet to peer...