Brandon Stafford

Yes, that would be an improvement. Patches welcome.

If it doesn't break the validation code we've got, sounds great. I would be hesitant to include other models if it breaks our validation, and we have no better way...

Support of Numpy is desirable, as long as it doesn't become a dependency. The approach outlined above sounds good to me. Patches welcome!

Just a note that this is partially completed, as described in #74. I'm not sure what work remains, but help is still wanted.

That does seem weird. To investigate more, I'd recommend looking at the elements of `get_radiation_direct`, which can be found here: https://github.com/pingswept/pysolar/blob/master/pysolar/radiation.py#L43

I suspect you're on the right track here. Any thoughts on when or why asin is getting called with values above 1? I'm hesitant to just wipe out values above...

If anyone can replicate this, I'd be interested in the details.

I’d guess that it’s a divide-by-zero error. EXTR1 represents extraterrestrial radiation. Generally, that should be around 1366 W/m^2, so it’s probably just being tested weirdly, rather than a real bug...

Interesting. That certainly looks like a bug. Thanks for the test case. My guess is that some correction factor is blowing up as altitude nears zero. I’d welcome more details...

Yeah, that looks like a bug. Could you post the inputs that produced the error?