Pilwon Huh

Results 54 comments of Pilwon Huh

@SuhairZain Are you running it in Node.js?

@SuhairZain This library is not tested in react-native environment, but you're welcome to submit PR to support that as well.

@raybooysen PR for this would be a great idea. Thanks-

@spieglio Sounds like a great addition. Please feel free to contribute by submitting PR. Thanks-

@meteorpublish I agree this change will make writing contracts more flexible and easier to read, however it'll be a breaking change. Any suggestion for introducing this without touching existing API?

@meteorpublish Yes, you're right about v0.x. I however still wish to maintain this library that doesn't surprise existing users unless it's absolutely necessary. I prefer the cleaner `ib.contract({ ... })`...

@meteorpublish I am only maintaining this package. TypeScript rewrite or even enhancing with typescript definitions is highly desired but I unfortunately am not able to invest much time these days....

@meteorpublish Please refer to my response https://github.com/pilwon/node-ib/issues/143#issuecomment-510891432 You should be able to pass any type of order to `.placeOrder(id, contract, order)` and I suggest looking for clues in the reference...

@yandreiy Please feel free to submit PR to fix this. Thanks-

@lewisdawson's PR #93 was merged and published as v0.1.20