pikson comments

Results 11 comments of


                                            pikson

conn session,only have Add(), not have Remove()

反正我测试着新老版本都不行，让我一度怀疑是不是go不行。。

conn session,only have Add(), not have Remove()

> > 我们更新到V1.6.0 版本，压测后发现，内存不断增长，一直不会释放。 > > 然而，我们将版本降低到V1.4.5，压测后发现内存会释放，希望新版本可以解决。 > > 看样子 1.4.5 不错啊，我也试试 1.4.5怎么样，还泄露不

conn session,only have Add(), not have Remove()

> 我怀疑有内存泄漏，无论再哪个版本，我们现在线上在使用，10w+的连接，给多少机器都没办法满足我是13万+的连接，之前是一直有内存泄露，不过测试了最近的1.6.2，问题还是没有解决，虽然开发者说解决了这个问题。希望你们也测试下。

conn session,only have Add(), not have Remove()

same with before. I will test again

bug: memory leak happening.

> Hey, @piksonGit It does not actually? yes, it's happening. my server have 64G memory. it ran out.

bug: memory leak happening.

> I will try to fix this issue. Thanks you feedback should I use s.Close() in OnDisconnect or OnError method?

> > To [#442 (comment)](https://github.com/googollee/go-socket.io/issues/442#issuecomment-835250470), please call `Close()` in `OnError()` when you don't want to continue the session. It's also safe to call `Close()` in `OnDisconnect()`. > > I will...