Pieter Vanderwerff

Results 17 comments of Pieter Vanderwerff

Yeah prettier prints based off the source position which is embedded in the AST. Our tool has a way to modify nodes without removing the source location. It’s just new...

Yeah it means the location information is not being set on the AST for prettier correctly. Try inspecting your AST nodes, from memory prettier looks at the a `range` array....

@nicolo-ribaudo Its not clear to me what the proposal is here? Is it to just remove the parsing logic for Flow but maintain existing AST node, transformation, scope analysis and...

> One option for now might be to add an option to @babel/preset-flow to use the Hermes-based parser Ok that makes sense and seems reasonable. There are a couple of...

Hermes parser does not support comment attachment. In general its a bad idea to rely on comments during your build process since people typically expect them to not change runtime...

@mjambon for my usecase (printing JavaScript) we need to only print the trailing comma if we break. I tried to implement it with the above approach and using `Format.pp_print_if_newline` inside...

I am running into this as well, for now i have just setup a switch to change column width of 68 to 67, what a weird bug.