Pieter Noordhuis

[wip] Run CI on Windows

1

This is a test.

The callouts to `databricks.*` in `databricks_cli/sdk/service.py` should be removed.

There's repetition of the same set of click option annotations before command functions. They can be generalized into a couple helper functions in `databricks_cli/utils`.

Configurable encoding for Hiredis::Reader

2

This would bring it up to par with hiredis-py.

This has been a tedious and manual process that should be automated.

Always propagate root context to child command

5

The context passed to the root command should propagate to its children not only on the first execution but also subsequent calls. Calling the same command multiple times is common...

Please read this before opening a new issue

1

> **Databricks recommends that you use newer Databricks CLI versions 0.200 and above instead of legacy Databricks CLI versions 0.17 and below (located in this repository). You can find the...

Close file descriptors after mapping ring buffer

1

No need to keep them open once the memory has been mapped. Also, we keep them as `int` on the shm connection, so they aren't cleaned up on destruction.

Use std::regex to parse uv sockaddr

1

The sockaddr parsing logic in `transport/uv/sockaddr.cc` could be done with `std::regex` instead. See https://github.com/pytorch/tensorpipe/pull/12.

Build with -Werror

1

Let's see what happens...