Pierre Allard

This PR adds CREATE products endpoint There are 3 "crappy" things: - We have to get identifiers from associated products uuids - We can't create a product by defining its...

XXXController should be renamed AdminXXXControllers

1

The "Game" controllers are used in routes like /admin/xxx/... This controllers should be renamed in AdminXXXControllers or be placed in a Admin folder, to be able to have a declaration...

I've done this: https://github.com/akeneo/badger/blob/master/src/Badger/GameBundle/Entity/BadgeInterface.php#L15 But another possibility is to remove "extends TaggableInterface" from this interface, and add "implements TaggableInterface" to "Badge". I think these 2 implementations are "code-correct", but have...

False positive : check 'save' return value or use 'save!'

1

Hi everybody I think I found a false positive using rails_best_practices, with this type of line: ``` @success = [email protected] ``` It can be a weird line, but I want...