Pierangelo Di Pilato

Results 458 comments of Pierangelo Di Pilato

Hi @giriraj-hh, is a fix something you can contribute?

Related https://github.com/cloudevents/sdk-java/issues/542, it's focused on Protobuf but the core and api modules should be implemented for the general batch format

With Kafka's [KIP-863: Reduce CompletedFetch#parseRecord() memory copy](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=225152035) this might be more relevant now

I think these comments are relevant here https://github.com/knative/pkg/issues/2560#issuecomment-1195840564 and https://github.com/knative/pkg/issues/2560#issuecomment-1195842825, in particular these parts > I'm curious what cert is the webhook presenting and see what's defined in your CA...

/test reconciler-tests

I think failures are unrelated ``` No local changes to save reviewdog: fail to get diff: GET https://api.github.com/repos/knative/eventing/pulls/7707: 406 Sorry, the diff exceeded the maximum number of files (300). Consider...

Knative operator, however, I don't think it is important even issuing a new `kubectl apply -f` will re-update the spec since missing or different fields will be re-added / updated