Pierangelo Di Pilato

Results 468 comments of Pierangelo Di Pilato

The deserializer only supports the Kafka protocol binding for cloudevents as per spec https://github.com/cloudevents/spec/blob/main/cloudevents/bindings/kafka-protocol-binding.md, I believe the records are not formatted as expected by the spec ?

> The only apparent solution in my mind for allowing a front-end application to send requests to a service in the Kubernetes cluster is to hardcode the external address in...

I think if Serving starts using the [`addresses`](https://github.com/knative/pkg/blob/ca5f1cee7df800daf2b5fd890075b3e4829cb7b0/apis/duck/v1/addressable_types.go#L83-L86) array and set both internal and external address, in your SinkBinding you could do something like: ```yaml apiVersion: sources.knative.dev/v1 kind: SinkBinding metadata:...

So, I would not complicate how we resolve the address for SinkBinding and instead modify the sink addressable to also expose the public address in the list that can be...

I would recommend proposing that option to Serving vs changing how we resolve addressables in Eventing

Ref: https://github.com/cloudevents/sdk-java/pull/603#pullrequestreview-1853465105

@vietj yes, `send` blocks on metadata updates for [`max.block.ms`](https://kafka.apache.org/documentation/#producerconfigs_max.block.ms): - doSend: https://github.com/apache/kafka/blob/839b886f9b732b151e1faeace7303c80641c08c4/clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java#L898-L906 - await metadata https://github.com/apache/kafka/blob/839b886f9b732b151e1faeace7303c80641c08c4/clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java#L1047 This is particularly evident when the Kafka cluster is down or unavailable