eventing
eventing copied to clipboard
Use a single trust bundle lister for SinkBinding reconciler
This should fix https://github.com/knative/eventing/issues/7597
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: matzew, pierDipi
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [matzew,pierDipi]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
So it's still happening ...
/hold
New changes are detected. LGTM label has been removed.
Codecov Report
Attention: Patch coverage is 0% with 24 lines in your changes are missing coverage. Please review.
Project coverage is 74.38%. Comparing base (
bcba98a) to head (2ed1025). Report is 96 commits behind head on main.
| Files | Patch % | Lines |
|---|---|---|
| pkg/eventingtls/trust_bundle.go | 0.00% | 24 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #7598 +/- ##
==========================================
- Coverage 74.44% 74.38% -0.07%
==========================================
Files 262 262
Lines 15077 15090 +13
==========================================
Hits 11224 11224
- Misses 3247 3260 +13
Partials 606 606
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Passed /test reconciler-tests_eventing_main
Unrelated
/test reconciler-tests
/test reconciler-tests
@pierDipi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| reconciler-tests_eventing_main | 2ed1025529f0ab9252e4cb1bff54bd168803d897 | link | true | /test reconciler-tests |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.
/remove-lifecycle stale