Marc Pichler

Results 510 comments of Marc Pichler

Hmm, AFAIK `@opentelemetry/instrumentation-pino` does not auto-register a diagnostics logger. The feature in https://github.com/open-telemetry/opentelemetry-js/pull/3366 is intended for the case that someone manually re-registers a diagnostics logger and they want to suppress...

I marked this as a `bug` and `priority:p4` (logspam that can be safely ignored)

This is unassigned. We're happy to accept contributions that fix this 🙂

Unassigned @dyladan as he likely won't have time to work on this. If anyone has time to work on this, please do so as this is a high-priority bug.

> I can take it. @rndD thank you 🙌 > Is a depth-limiter approach with a default of 10 good enough? Yes, I think that's a good approach.

Note: Transferred from the core repo as this is a feature request only concerns `@opentelemetry/instrumentation-aws-lambda`. This `feature-request` is pending approval/rejection by @jj22ee (component owner)

@blumamir has created [a really good write-up of this](https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/GUIDELINES.md). The reason why some of these are in `dependencies` is because they're in some way shape or form part of the...

Failing tests are unrelated, looks like some issue with the runners - I'll merge this in once they work again :slightly_smiling_face:

Failing tests are actually caused by #2445 - I'm not sure how to fix that yet. :disappointed: Edit: https://github.com/open-telemetry/opentelemetry-js-contrib/pull/2446 should fix it :slightly_smiling_face:

The [test failures now](https://github.com/open-telemetry/opentelemetry-js-contrib/actions/runs/11013435305/job/30581787109?pr=2380) seem related to the previous PR https://github.com/open-telemetry/opentelemetry-js-contrib/pull/2349 which seems to have introduced some flakiness in the tests. I've re-started, but it's something that we need to...