Pierre Goiffon

Results 130 comments of Pierre Goiffon

> RedefineChildNode is covered. Indeed : https://github.com/Combodo/iTop/pull/329/files?show-viewed-files=true&file-filters%5B%5D=#diff-da66df5f4729571ab380f32efac6c09f98f4993db648ec4b89ee51ab9c71c5e5R662 Thanks, ok for me !

Hello, Many thanks for this fix ! It was already known (N°2013) but no fix was available for now.

Discussed [on the community slack](https://itopbycombodo.slack.com/archives/C02D0C7NNQG/p1665141636698289) : seems like a regression brought by https://github.com/Combodo/iTop/commit/ca28eeb596465ce164526c609bb6e6935195e7be#diff-8c55850df4e71248c227c080e065cf48f4c8bae63ac7e3bcb2864a0a5a20b876L1246-L1260

When we did the review I was thinking about `js/jquery.hotkeys.js` that is here since 684e9e35 : I introduced it to handle... Ctrl+Enter shortcut in the run query screen :) Honestly...

Thanks ! Indeed the GitHub shortcut is exactly what we needed. We'll have to test if the PR JS code triggers when doing Command+Enter on Mac...

Can you also update the run query screen to use the same code ? And remove the jquery hotkeys lib ?

Indeed you're right, second solution is what is made everywhere in the datamodel ! I will switch to it !

Didn't find any Attachment children in the clients customization (details are in N°4081) Setting this PR to be reviewed for next functional review !

Just updated the description to add the SF ticket reference. Many thanks for the fix Lars ! There is also [another ticket on a similar prb with Microsoft Edge](https://sourceforge.net/p/itop/tickets/2114/), I'll...

Seen during support PR review : we saw apcEmulationTest was breaking... Because this test class is loading a php file to mock : - MetaModel::GetConfig - utils::GetCachePath - apc_cache_emulation.max_entries config...