:bug: navigation menu z-index workaround for safari

[larhip]

Hi there,

I know officially you are not supporting the Browser Safari and I am also aware of the facts that the following fix seems to be more related to an issue with Safari than with iTop.

But anyhow since Safari is a widely used browser (at least among Mac users), this PR should workaround the issue regarding the hidden menu bar (see also: https://sourceforge.net/p/itop/discussion/itop-hub/thread/fc97ec4a10/?limit=25#1cc0/9930) it seems to be related to an issue with the z-index (https://stackoverflow.com/questions/40895387/z-index-not-working-on-safari-fine-on-firefox-and-chrome)

With this small css snippet in this PR the issue is gone, I should not have an impact on other browsers.

Reference: https://sourceforge.net/p/itop/tickets/2104/

[Molkobain]

Hello Lars,

Can you add a screenshot of the visual issue before the fix. And can you add screenshots of Safari / Chrome / Firefox working correctly after the fix.

As this is a workaround for an unsupported browser, we might consider it because you are a valued contributor, but only if it doesn't affect the others. Also, in that kind of fix we like to add a comment explaining why we did that and where the solution came from. I'll make a suggestion in the PR

Cheers, Guillaume

[Molkobain]

Can you also move the fix to the css/backoffice/_shame.scss file please?

[larhip]

Thanks for your fast feedback @Molkobain !

Moved the fix into _shame.scss also added your suggested comments.

Behavior in safari before the fix:

Behavior in safari after the fix:

Behavior in Firefox after the fix (still the same):

Behavior in Chrome after the fix (still the same):

Enjoy your community Event! :v:

[Molkobain]

Thanks for the update Lars, it will help pushing this forward. Will keep you updated early october during the next technical review.

Enjoy your community Event! ✌️

I could not make it this year 😭😭 But I'm sure it was great 😊

Cheers! Guillaume

[piRGoif]

Just updated the description to add the SF ticket reference. Many thanks for the fix Lars !

There is also another ticket on a similar prb with Microsoft Edge, I'll have a look to check if your fix address it.

[larhip]

There is also another ticket on a similar prb with Microsoft Edge, I'll have a look to check if your fix address it.

I am afraid my fix will not address that issue as well, since I just added some css for the navigation menu not for any other components. But for sure it might be the MS Edge problem got a similar root cause (something related to z-index...) To be honest: I am not 100 percent sure whether I understood the concept of z-index vs translateZ in all details 🙈

[Molkobain]

Accepted during technical review (pending the change / answer on the generic property instead of the webkit one)

[Molkobain]

On a side note, @BenGrenoble found this macOS emulation on Linux. We are currently trying to reproduce the bug on it. Even though we won't do extensive testing on Safari, it could be a good way to reproduce bugs you report to ease the acceptation process.

[Molkobain]

Accepted during functional review. Will be part of iTop 3.1

I'll create the corresponding bug in our tracker and update the PR's title.

[logicsthinkaboutit]

hey, Why didn't you include the existing and known error as a bug fix in the new 3.0.3 version? Now the error is there again.

[piRGoif]

Why didn't you include the existing and known error as a bug fix in the new 3.0.3 version?

Hello, This was the product team decision. As said widely in this PR and on the various SourceForge discussions, we don't have ways to reproduce the bug and no Apple products are on our QA chain. When we cannot guarantee the quality of a bugfix, we prefer to include it only in next major release, as it allows wider manual testing.