Pooya Parsa comments

Results 2281 comments of


                                            Pooya Parsa

Documentation autoSubfolderIndex casing incorrect

#2494

Preserving directives

Have you checked if, rollup has an option to preserve directives? I think as default behavior we should also preserve them if possible.

fix!: do not automatically return `Sec-WebSocket-Protocol` header

Thx for PR. I want to try avoiding breaking change if possible. Couldn't we check to only do this if custom `Sec-WebSocket-Protocol` is returned in upgrade hook?

fix!: do not automatically return `Sec-WebSocket-Protocol` header

(if we could have a test would be nice then we can try different options)

fix!: do not automatically return `Sec-WebSocket-Protocol` header

> we also need to support the case where the user omits the sec-websocket-protocol header to disagree with using the provided subprotocols during the handshake: Perhaps we can allow `headers["sec-websocket-protocol"]...

fix(runtime-core): allow using `getCurrentInstance` with multiple builds of vue

Thanks for quick feedback @yyx990803 > since currentInstance isn't the only global singleton that the Vue runtime relies on. Some other examples include the reactivity tracking maps and built-in VNode...

fix(runtime-core): allow using `getCurrentInstance` with multiple builds of vue

Update: I have updated the tests. Also made this change completely opt-in via a private API. When `globalThis.__vue_ctx__` is set, vue reuses the context over package-scoped context.

fix(runtime-core): allow using `getCurrentInstance` with multiple builds of vue

Using warning and global setters, i think we will have less issues however: - We probably need to avoid showing this warning when same version of Vue is from different...

fix: perserve directives

Thanks for PR, it is nice feature, however I'm wondering if it is worth to add a new rollup dependency for this (while the main usage of directives, is mainly...

The cache on the Cloudflare page does not expire

https://github.com/nitrojs/nitro/issues/2378#issuecomment-2575876133