Jack

Results 157 comments of Jack

hey @arfeo comments should be addressed, let me know if there is anything else.

Hey @arfeo, considering its another working week im only going to get a small amount of time to get the remaining tests done, so figured id get a draft pr...

No rush in the slightest 👍 As i said still have a few more tests to go :)

hey @arfeo ! finally got some time today to have another crack at the tests. When you get time please give it a review :) the only set of tests...

ill split them out over the weekend. i agree the pr is fairly large. as for the tests they are all working i just couldn't figure out how to test...

@noftaly thanks for the input. im a bit of a scrub when it comes to ESModules (as you can tell haha). i got the tests passing by applying the babel...

@noftaly Hey again, i confirmed that the revert + .tsm file works for import with the `type: module` in package.json :+1: and require still works as it did before ive...

Hey @arfeo, Hope you have been well! This Pr is ready for review when you get a chance 👍 The only item left to cross off is how to test...

one final followup: finished the cli context tests so it should be fully ready now :+1:

Hey @arfeo, Sorry i didnt see the last reply. I have created 3 prs. https://github.com/arfeo/npm-add-dependencies/pull/23 - node update https://github.com/arfeo/npm-add-dependencies/pull/24 - test update https://github.com/arfeo/npm-add-dependencies/pull/25 - typescript update Linting - TODO once...