Matthew Martin

Looks like Sebastian has explicitly allowed z-sy-h to incorporate f-sy-h code https://github.com/zsh-users/zsh-syntax-highlighting/issues/434#issuecomment-606654142 . Just looking at the directory structure, it seems there's been a significant refactoring since the z-sy-h fork....

I happen to be working in the same area. Looking to add `__next__` which is proving troublesome because it can raise an exception. But I've added `__repr__` and `__hash__` on...

Looks generally ok. I know the cut was already there, but the cut, sed, and uniq can be done with zsh features. That is ```zsh typeset -a available_session_options available_session_options=( $(...

While it'd be preferable to have a proper solution like this PR, in the mean time I've resorted to generating javascript to paste into the extension's console. I've documented the...

Seems to be a duplicate of #885 .

Since themes will be sourced or called, the main theme could support both. It may be a good idea for z-sy-h to provide a `_supports_256_color` callable so each theme doesn't...

Will the highlighter interface change to allow for autoloaded highlighters?

I was tempted to add the label too. Applied.

Something like ``` diff --git a/highlighters/main/main-highlighter.zsh b/highlighters/main/main-highlighter.zsh index 647eb8b..e905268 100644 --- a/highlighters/main/main-highlighter.zsh +++ b/highlighters/main/main-highlighter.zsh @@ -492,10 +492,14 @@ _zsh_highlight_highlighter_main_paint() local -a match mbegin mend local MATCH; integer MBEGIN MEND if...

I certainly prefer a whitelist, and agree it's the correct approach. From the `$AUTOINCREMENT` example it sounds like no parameters should ever be expanded since they could have side effects....